-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on ostruct #2535
Comments
As part of this fix, json 2.7.2 also has to be installed (since json 2.7.1 uses ostruct). Normally, it gets added by rubocop. However, if lint is not enabled, it needs to be installed for simplecov/deep-cover. So if Ruby is > 3.3.4, add json as a coverage dependency. logger is also being removed from stdlib, so for now, it needs to be declared as a dependency in the Gemfile if Ruby > 3.3.4. |
To be clear, this doesn't solve the entire probably being introduced by Ruby's continued gemfication of APIs previously in stdlib. But it at least solves the direct dependency that Asciidoctor PDF has on the APIs being removed. |
The ostruct library is being repackaged as a gem and removed from Ruby's standard library (stdlib). Replace OpenStruct with an internal implementation to avoid this whole mess. The custom class should be named
Asciidoctor::PDF::ThemeData
since the only use of OpenStruct in Asciidoctor PDF is for the theme data. This also gives us the opportunity to optimize this object for more efficient access in the future.The text was updated successfully, but these errors were encountered: