Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warning about missing character in fallback font when using inline image #2492

Closed
mojavelinux opened this issue Feb 12, 2024 · 1 comment
Assignees
Milestone

Comments

@mojavelinux
Copy link
Member

When an inline image falls in the part of a paragraph that gets split onto the next page, and the theme uses at least one fallback font, Asciidoctor PDF incorrectly warns about the fallback font missing character the \u2063. This character is only a placeholder for the inline image and is not meant to be rendered. However, when Prawn analyzes the fragments that fall to the next page, it sees the placeholder and tries to find the font for it. Asciidoctor PDF should intercept this analysis in Prawn and skip the image fragment.

The reason Prawn sees the placeholder is because the image arranger has already run on the paragraph when the fragments get split across pages. In other words, the text of the image fragment is now a placeholder. Although the placeholder is never rendered, it's present when Prawn is analyzing the font support for the glyphs in the remaining fragments.

@mojavelinux mojavelinux self-assigned this Feb 12, 2024
@mojavelinux mojavelinux added this to the v2.3.x milestone Feb 12, 2024
@mojavelinux
Copy link
Member Author

Related to #2453.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Feb 12, 2024
…ack font when inline image is advanced to next page

skip fragment for inline image when analyzing fragment for font support
mojavelinux added a commit that referenced this issue Feb 16, 2024
… font when inline image is advanced to next page

skip fragment for inline image when analyzing fragment for font support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant