Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border color for element should fall back to value of base-border-color #2134

Closed
mojavelinux opened this issue May 3, 2022 · 0 comments
Closed

Border color for element should fall back to value of base-border-color #2134

mojavelinux opened this issue May 3, 2022 · 0 comments
Assignees
@mojavelinux
Labels
improvement v2.0.0
Milestone
v2.0.0

Comments

@mojavelinux
Copy link
Member

If a border color (or column rule color) is not specified for an element, the value should fall back to base-border-color. This allows the border to be toggled solely through the width attribute. For example:

base:
  border-color: BBBBBB
heading:
  h2:
    border-width: [0, 0, 2, 0]

Although this won't impact the built-in themes, the behavior can make creating new themes easier.
@mojavelinux mojavelinux self-assigned this May 4, 2022
@mojavelinux mojavelinux added this to the v2.0.0 milestone May 4, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 4, 2022
@mojavelinux
resolves asciidoctor#2134 use base-border-color as default border col…
dc5498a 
…or; control appearance of border on border-width value alone

* if border-color for element is not set or nil, fall back to base-border-color
* don't set default value for base_border_color key on theme object
* change fallback value for table border color to base-border-color
* change fallback value for thematic break stroke color to base-border-color
* don't use base-border-width as fallback width for admonition column rule
* interpret nil value in table border color array as transparent
* interpret nil value in table border width array as 0
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 4, 2022
@mojavelinux
resolves asciidoctor#2134 use base-border-color as default border col…
1163c52 
…or; control appearance of border on border-width value alone

* if border-color for element is not set or nil, fall back to base-border-color
* don't set default value for base_border_color key on theme object
* change fallback value for table border color to base-border-color
* change fallback value for thematic break stroke color to base-border-color
* don't use base-border-width as fallback width for admonition column rule
* interpret nil value in table border color array as transparent
* interpret nil value in table border width array as 0
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 4, 2022
@mojavelinux
resolves asciidoctor#2134 use base-border-color as default border col…
4e08bbb 
…or; control appearance of border on border-width value alone

* if border-color for element is not set or nil, fall back to value of base-border-color
* don't set default value for base_border_color and base_border_width keys on theme object
* change fallback value for table border color to base-border-color
* change fallback value for thematic break stroke color to base-border-color
* don't use base-border-width as fallback width for admonition column rule
* interpret nil value in table border color array as transparent
* interpret nil value in table border width array as 0
* don't set border colors in base theme so they can be controlled using base-border-color when extending theme
* set border width on sidebar in base theme
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 4, 2022
@mojavelinux
resolves asciidoctor#2134 use base-border-color as default border col…
fe9dc27 
…or; control appearance of border on border-width value alone

* if border-color for element is not set or nil, fall back to value of base-border-color
* don't set default value for base_border_color and base_border_width keys on theme object
* change fallback value for table border color to base-border-color
* change fallback value for thematic break stroke color to base-border-color
* don't use base-border-width as fallback width for admonition column rule
* interpret nil value in table border color array as transparent
* interpret nil value in table border width array as 0
* don't set border colors in base theme so they can be controlled using base-border-color when extending theme
* set border width on sidebar in base theme
@mojavelinux mojavelinux mentioned this issue Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
improvement v2.0.0
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@mojavelinux