Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow border width to be set per edge of block images #2119

Closed
mojavelinux opened this issue May 1, 2022 · 0 comments
Closed

Allow border width to be set per edge of block images #2119

mojavelinux opened this issue May 1, 2022 · 0 comments
Assignees
@mojavelinux
Labels
bug v2.0.0
Milestone
v2.0.0

Comments

@mojavelinux
Copy link
Member

In theory, the theme should support setting a border width per edge of block images. However, due to a check in the code that assumes the value is a number, specifying an array causes the converter to crash. This check should be amended to account for an array value. A test should be added to confirm that the border can be set per side.
@mojavelinux mojavelinux added the bug label May 1, 2022
@mojavelinux mojavelinux added this to the v2.0.0 milestone May 1, 2022
@mojavelinux mojavelinux self-assigned this May 1, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 2, 2022
@mojavelinux
resolves asciidoctor#2119 allow border width of block image to be spe…
bb9d91d 
…cified as an array

fix condition that assumed value was singular
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 2, 2022
@mojavelinux
resolves asciidoctor#2119 allow border width of block image to be spe…
9dc1c16 
…cified as an array

fix condition that assumed value was singular
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 2, 2022
@mojavelinux
resolves asciidoctor#2119 allow border width of block image to be spe…
0ac805f 
…cified as an array

fix condition that assumed value was singular
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug v2.0.0
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@mojavelinux