Update apache-poi from 3.11 to 3.17 #15

asl-acx · 2018-09-20T15:41:00Z

No description provided.

… 1.3

sonarqubecloud

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 16

Including the following issue(s) which could not be reported in line:

Code Smell: Remove this use of "getCellType"; it is deprecated. (more)
Code Smell: Remove this use of "EMU_PER_POINT"; it is deprecated. (more)
Code Smell: Remove this use of "CELL_TYPE_BLANK"; it is deprecated. (more)
Code Smell: Remove this use of "BLACK"; it is deprecated. (more)

See all issues in SonarCloud

sonarqubecloud · 2018-09-20T15:52:43Z

...spudsoft.birt.emitters.excel/src/org/apache/poi/xssf/usermodel/XSSFVMLHeaderFooterImage.java

-	super(part, rel);
-	read(getPackagePart().getInputStream());
-    }
-
    protected void read(InputStream is) throws IOException, XmlException {
 	XmlObject root = XmlObject.Factory.parse(new EvilUnclosedBRFixingInputStream(is));


Code Smell: Remove this use of "EvilUnclosedBRFixingInputStream"; it is deprecated. (squid:CallToDeprecatedMethod)

See it in SonarCloud

sonarqubecloud · 2018-09-20T15:52:44Z

...uk.co.spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/FilteredSheet.java

+    }
+
+    /*
+    public void setZoom(int numerator, int denominator) {


Code Smell: This block of commented-out lines of code should be removed. (squid:CommentedOutCodeLine)

See it in SonarCloud

sonarqubecloud · 2018-09-20T15:52:44Z

...uk.co.spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/FilteredSheet.java

+    // FIXME
+    public Comment getCellComment(int row, int column) {
+        return sheet.getCellComment(new CellAddress(row, column));
+        //return sheet.getCellComment(row, column);


Code Smell: This block of commented-out lines of code should be removed. (squid:CommentedOutCodeLine)

See it in SonarCloud

sonarqubecloud · 2018-09-20T15:52:44Z

...spudsoft.birt.emitters.excel/src/org/apache/poi/xssf/usermodel/XSSFVMLHeaderFooterImage.java

@@ -250,6 +242,12 @@ protected void write(OutputStream out) throws IOException {
 	}
 	rootCursor.dispose();

+	// google "POIXMLDocumentPart DEFAULT_XML_OPTIONS"
+	XmlOptions DEFAULT_XML_OPTIONS = new XmlOptions();


Code Smell: Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. (squid:S00117)

See it in SonarCloud

actually it should be static final variable in this class

sonarqubecloud · 2018-09-20T15:52:44Z

...o.spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/StyleManagerUtils.java

 		if(fontWeight == null) {
-			return 0;
+			return false;
 		}
 		if("bold".equals(fontWeight)) {


Code Smell: Replace this if-then-else statement by a single return statement. (squid:S1126)

See it in SonarCloud

sonarqubecloud · 2018-09-20T15:52:44Z

...o.spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/StyleManagerUtils.java

@@ -294,7 +295,7 @@ public static boolean cellIsEmpty(Cell cell) {
 		if( cellStyle == null ) {
 			return true;
 		}
-		if( cellStyle.getFillPattern() == CellStyle.NO_FILL ) {
+		if( cellStyle.getFillPattern() == FillPatternType.NO_FILL.getCode() ) {


Code Smell: Replace this if-then-else statement by a single return statement. (squid:S1126)

See it in SonarCloud

sonarqubecloud · 2018-09-20T15:52:45Z

....spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/StyleManagerXUtils.java

@@ -213,7 +214,7 @@ public Font correctFontColorIfBackground( FontManager fm, Workbook wb, BirtStyle
 		int bgRgb[] = parseColour( bgColour == null ? null : bgColour.getCssText(), "white" );

 		XSSFColor colour = ((XSSFFont)font).getXSSFColor();
-		int fgRgb[] = rgbOnly( colour.getARgb() );
+		int fgRgb[] = rgbOnly( colour.getARGB() );


Code Smell: Move the array designator from the variable to the type. (squid:S1197)

See it in SonarCloud

sonarqubecloud · 2018-09-20T15:52:45Z

...uk.co.spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/FilteredSheet.java

+        return sheet.getDrawingPatriarch();
+    }
+
+    // FIXME


Code Smell: Take the required action to fix the issue indicated by this comment. (squid:S1134)

See it in SonarCloud

sonarqubecloud · 2018-09-20T15:52:45Z

...o.spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/StyleManagerUtils.java

@@ -699,7 +700,7 @@ public void applyNumberFormat(Workbook workbook, BirtStyle birtStyle, CellStyle
 	protected void addFontAttributes( AttributedString attrString, Font font, int startIdx, int endIdx) {
 		attrString.addAttribute(TextAttribute.FAMILY, font.getFontName(), startIdx, endIdx);
 		attrString.addAttribute(TextAttribute.SIZE, (float)font.getFontHeightInPoints(), startIdx, endIdx);
-        if (font.getBoldweight() == Font.BOLDWEIGHT_BOLD) attrString.addAttribute(TextAttribute.WEIGHT, TextAttribute.WEIGHT_BOLD, startIdx, endIdx);
+		if (font.getBold()) attrString.addAttribute(TextAttribute.WEIGHT, TextAttribute.WEIGHT_BOLD, startIdx, endIdx);
        if (font.getItalic() ) attrString.addAttribute(TextAttribute.POSTURE, TextAttribute.POSTURE_OBLIQUE, startIdx, endIdx);


Code Smell: This line will not be executed conditionally; only the first line of this 2-line block will be. The rest will execute unconditionally. (squid:S2681)

See it in SonarCloud

sonarqubecloud · 2018-09-20T15:52:45Z

...o.spudsoft.birt.emitters.excel/src/uk/co/spudsoft/birt/emitters/excel/StyleManagerUtils.java

@@ -294,7 +295,7 @@ public static boolean cellIsEmpty(Cell cell) {
 		if( cellStyle == null ) {
 			return true;
 		}
-		if( cellStyle.getFillPattern() == CellStyle.NO_FILL ) {
+		if( cellStyle.getFillPattern() == FillPatternType.NO_FILL.getCode() ) {


Code Smell: Remove this use of "getFillPattern"; it is deprecated. (squid:CallToDeprecatedMethod)

See it in SonarCloud

eryabitskiy-acx · 2018-09-20T16:08:27Z

common/apache-poi/META-INF/MANIFEST.MF

+ target/poi-ooxml-3.17.jar,
+ target/poi-ooxml-schemas-3.17.jar,
+ target/curvesapi-1.04.jar,
+ target/commons-collections4-4.1.jar


I would move collections to separate bundle, so it can be reused without apache poi.

eryabitskiy-acx · 2018-09-20T16:09:12Z

common/apache-poi/META-INF/MANIFEST.MF

+ org.apache.commons.collections4.splitmap,
+ org.apache.commons.collections4.trie,
+ org.apache.commons.collections4.trie.analyzer,
+ com.graphbuilder.curve,


no need to expose graphbuilder packages

eryabitskiy-acx · 2018-09-20T16:09:58Z

common/apache-poi/pom.xml

 	<packaging>eclipse-plugin</packaging>

 	<dependencies>
 		<dependency>
 			<groupId>org.apache.poi</groupId>
 			<artifactId>poi</artifactId>
-			<version>3.11</version>
+			<version>3.17</version> <!-- latest 4.0.0 -->


comments about latest are very relative. today it is latest, tomorrow it is not true anymore

asl-acx added 3 commits September 20, 2018 16:45

Update apache-poi from 3.11 to 3.17, update ooxml-schemas from 1.1 to…

52bc9f4

… 1.3

Update apache-poi from 3.11 to 3.17, update ooxml-schemas from 1.1 to…

497fd71

… 1.3

Merge branch 'master' into apache_poi_3_17

3f72f4f

sonarqubecloud bot reviewed Sep 20, 2018

View reviewed changes

eryabitskiy-acx reviewed Sep 20, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update apache-poi from 3.11 to 3.17 #15

Update apache-poi from 3.11 to 3.17 #15

asl-acx commented Sep 20, 2018

sonarqubecloud bot left a comment

sonarqubecloud bot Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

eryabitskiy-acx Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

sonarqubecloud bot Sep 20, 2018

eryabitskiy-acx Sep 20, 2018

eryabitskiy-acx Sep 20, 2018

eryabitskiy-acx Sep 20, 2018

Update apache-poi from 3.11 to 3.17 #15

Are you sure you want to change the base?

Update apache-poi from 3.11 to 3.17 #15

Conversation

asl-acx commented Sep 20, 2018

sonarqubecloud bot left a comment

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

eryabitskiy-acx Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

sonarqubecloud bot Sep 20, 2018

Choose a reason for hiding this comment

eryabitskiy-acx Sep 20, 2018

Choose a reason for hiding this comment

eryabitskiy-acx Sep 20, 2018

Choose a reason for hiding this comment

eryabitskiy-acx Sep 20, 2018

Choose a reason for hiding this comment