Skip to content

Commit

Permalink
Make adjustments according to CRAN feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
asardaes committed Feb 20, 2020
1 parent c4148b9 commit 363f2cd
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 11 deletions.
9 changes: 5 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ Type: Package
Title: Multi-Threaded, Coercion-Free Implementations of Common Row-Wise Operations
Description: Fast row-oriented operations implemented in C++, all of which are multi-threaded by
leveraging 'RcppParallel' and 'RcppThread'. Virtually no deep copies of input data are made,
even of character data thanks to Boost's 'string_ref'. In contrast to other functions, the ones
in this package support data frames with differently typed columns as input without coercion to
a matrix, performing on-the-fly type promotion following R rules, where necessary.
even of character data thanks to the 'string_ref' class from the C++ 'Boost' library. In
contrast to other functions, the ones in this package support data frames with differently typed
columns as input without coercing to a matrix, performing, if necessary, on-the-fly type
promotion according to R rules (like transforming logicals to integers to allow summation).
Version: 0.1.0
Depends:
R (>= 3.1.0)
Expand All @@ -22,7 +23,7 @@ LinkingTo:
RcppThread
Suggests:
testthat
Date: 2020-02-10
Date: 2020-02-20
Authors@R: c(
person("Alexis", "Sarda-Espinosa", role=c("cre", "aut"), email="alexis.sarda@gmail.com")
)
Expand Down
7 changes: 4 additions & 3 deletions R/pkg.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
#'
#' Fast row-oriented operations implemented in C++, all of which are multi-threaded by leveraging
#' \pkg{RcppParallel} and \pkg{RcppThread}. Virtually no deep copies of input data are made, even of
#' character data thanks to Boost's `string_ref`. In contrast to other functions, the ones in this
#' package support data frames with differently typed columns as input without coercion to a matrix,
#' performing on-the-fly type promotion following R rules, where necessary.
#' character data thanks to the 'string_ref' class from the C++ 'Boost' library. In contrast to
#' other functions, the ones in this package support data frames with differently typed columns as
#' input without coercing to a matrix, performing, if necessary, on-the-fly type promotion according
#' to R rules (like transforming logicals to integers to allow summation).
#'
#' Start by looking at [op_ctrl()].
#'
Expand Down
23 changes: 22 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,27 @@

## Initial release
This is the first version of the package.
This is the 1st revision for the initial submission of the package.
The following adjustments have been made based on the received feedback:

* Single quotes have been added to 'Boost' in the description.
Used packages were already quoted.
* The description has been reworded to hopefully make it more understandable.

Some remarks:

* All used packages are included in the DESCRIPTION file,
but some are only in the LinkingTo section.
Package 'BH', for instance, doesn't export any functions,
so it couldn't be included in Depends or Imports.
* No specific functions are mentioned in the description.
'string_ref' is a class, not a function;
this detail has been added to the description.
* 'Type promotion according to R rules' means that, for example,
an integer and a logical can be added together by promoting the logical to an integer.
R has some particularities in this regard, e.g.,
promoting a logical to a character results in the strings 'TRUE' or 'FALSE'.
This has been taken into account in the package,
and the description now mentions a simple example thereof.

## Test environments
* Local GNU/Linux, R release
Expand Down
8 changes: 5 additions & 3 deletions man/wiserow-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 363f2cd

Please sign in to comment.