Ensure that subroutes also display the selected nav, take 2 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalant
force-pushed
the
jgravois-more-selected-nav-links
branch
from
6ba1967
to
a5d409c
Compare
|
I forgot to mention, you're also welcome to just pile commits onto the PRs I already have open too. |
|
RIght! I forgot I have access to your repo.
…On Wed, Jan 22, 2020 at 9:06 AM john gravois ***@***.***> wrote:
I forgot to mention, you're also welcome to just pile commits onto the PRs
I already have open too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54?email_source=notifications&email_token=AAA3BOGJ4QONTP3BGKWKMCTQ7B4HRA5CNFSM4KJ52Y62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJULEYQ#issuecomment-577286754>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3BOB7C27EO5CHSAQW75LQ7B4HRANCNFSM4KJ52Y6Q>
.
|
|
yeah. I think I gave you permission manually, but its also just a handy (new) default in GitHub to give maintainers push access to the forked repo branch when a PR is opened.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jgravois I checked out your PR to play with (and to try to remember Ruby!). I concluded that we were getting into enough tweaky logic that it was important to have tests. That took me down a rabbit hole of how to best test the helper methods.
Here's the end result. The changes are probably overkill but it was fun to relearn a bit.
The
tab_itemmethod is I think a bit clearer to understand, and it now has tests. These changes also change the Visits tab URL to just point at/visitswhich I think would have made the changes you were trying to make easier too.