Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last day of month #3

Merged
merged 2 commits into from
Feb 19, 2022
Merged

Add last day of month #3

merged 2 commits into from
Feb 19, 2022

Conversation

rdehuyss
Copy link
Contributor

Hi Ahmed,

as I saw your solution, I also added an extra option to add the last of month.

Hope you like it!

@asahaf
Copy link
Owner

asahaf commented Feb 19, 2022

Thanks, we need to make sure that we can handle the case when both last day of month and last specific day of the month are specified.

@asahaf
Copy link
Owner

asahaf commented Feb 19, 2022

The current solution is when the last day of the month is specified, the last week day of the month is ignored. Should we throw an exception of invalid expression if both are specified?

@rdehuyss
Copy link
Contributor Author

That's indeed a good idea.

@asahaf
Copy link
Owner

asahaf commented Feb 19, 2022

could you please update the PR

@rdehuyss
Copy link
Contributor Author

Done!

@asahaf
Copy link
Owner

asahaf commented Feb 19, 2022

great! thank you

@asahaf asahaf merged commit d423237 into asahaf:master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants