Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources hook #65

Closed
wants to merge 5 commits into from
Closed

Conversation

yujincheng08
Copy link
Contributor

@yujincheng08 yujincheng08 commented Sep 1, 2020

A naive and ugly implementation, aiming to implement resources hook in non-root devices (by Xpatch framework).

Not tested very carefully, so some functions may not work properly or it may crash in some cases.

Most codes are copied and modified from EdXposed & dreamland.

Welcome any comment and modification.

@ghost
Copy link

ghost commented Sep 2, 2020

Well, nice work, but those changes may lead crash on Android 11 devices.
Please create a new branch and take those changes to new branch, then make a new pull request and submit it.
Framework files changes on 11 and we should not use compileOnly but reflection.

@yujincheng08
Copy link
Contributor Author

@lianglixin Many thx for ur suggestions. Actually I cannot submit a pull request to a new branch but the collaborators could merge my pr to a new branch, so there's nothing to do with me about the branch stuff.
And for Android P, I think the framework changes you mentioned are mainly affecting the hidden-api-stubs, which is not changed in Android P (as far as I refer to the changes on EdXposed). And for non-compileOnly part, I supposed I used reflection as much as possible.

In fact, I am not an expert in Android Development, so I am always hoping there could be someone helping me to perfect this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant