Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move deformable detr safe loading code #1055

Merged
merged 6 commits into from
Dec 18, 2024
Merged

move deformable detr safe loading code #1055

merged 6 commits into from
Dec 18, 2024

Conversation

HenryL27
Copy link
Collaborator

@HenryL27 HenryL27 commented Dec 4, 2024 •
edited
Loading

something something lockfile something something deduplication

@HenryL27
factor around deformable detr loading/lockfile management for use wit…
0700b11 
…h deformable table extractor

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27
remove unused global variable
9b5a9e9 
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
alexaryn
alexaryn reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@alexaryn alexaryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the to() needs to be inside the lock. Without the to() I don't think it knows what device to target. Without that, I don't see how it could do JITC for the correct GPU instruction set.

@HenryL27
move .to(device) iniside the lock
ea27bcf 
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
alexaryn
alexaryn approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@alexaryn alexaryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Hope it works.

lib/sycamore/sycamore/utils/model_load.py Outdated Show resolved Hide resolved
@HenryL27
jitpick
0a8a2b1 
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27
set deformable table extractor choose_device detr=True
4f49ede 
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27
Misc table transformers post-processing (#1077)
7c3ad39 
* misc postprocessing tweaks

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

* typo

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

---------

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27 HenryL27 merged commit 0f92e7a into main Dec 18, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexaryn alexaryn alexaryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenryL27 @alexaryn