Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark package as arch independent #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sertonix
Copy link

Otherwise the generated file will check whenever the 32/64 bit-ness matches. Since this is a header only library this check shouldn't exist.

Ref https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#generating-a-package-version-file

@arximboldi
Copy link
Owner

Thank you very much!

It seems there are some formatting issues in the CMake code, can you please run cmake-format, ideally in the nix-shell so it uses the same version as we do... also running the nix-shell will set up some pre-commit hooks that will prevent this issue in the future.

Otherwise the generated file will check whenever the 32/64 bit-ness matches. Since this is a header only library this check shouldn't exist.

Ref https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#generating-a-package-version-file
@sertonix
Copy link
Author

sertonix commented Nov 14, 2024

cmake-format now passes but it is basically just working around the fact that cmake-format doesn't understand ARCH_INDEPENDENT: cmakelang/parse/funs/standard_modules.py#L1891

@arximboldi
Copy link
Owner

Thank you! Agree that it looked better before but tooling is key :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants