Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add DiscreteWeibull #239

Merged
merged 5 commits into from
May 5, 2023
Merged

Conversation

aleicazatti
Copy link
Collaborator

@aleicazatti aleicazatti commented Apr 27, 2023

Description

Add DiscreteWeibull distribution. Issue #236

WIP:

  • Tests for this distribution are not implemented yet.
  • _fit_moments function is not implemented yet. "The moments of this distribution do not have closed forms and therefore the parameters cannot be estimated by ordinary techniques" https://ieeexplore.ieee.org/document/44179
  • plot_ppf method raises a RuntimeWarning: divide by zero encountered in log return np.ceil(((np.log(1 - p) / np.log(self.q)) ** (1 / self.beta)) - 1)

Checklist

  • Code style is correct (follows pylint and black guidelines)
  • New features are properly documented (with an example if appropriate)
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)

aleicazatti and others added 2 commits May 3, 2023 19:14
Co-authored-by: Osvaldo A Martin <aloctavodia@gmail.com>
@aloctavodia
Copy link
Contributor

"DiscreteWeibull" is missing from init_vals https://github.com/arviz-devs/preliz/blob/33e9a74df3ee364c164c0984649de4f24cc2c649/preliz/internal/distribution_helper.py

@aloctavodia aloctavodia merged commit d49d721 into arviz-devs:main May 5, 2023
aloctavodia added a commit that referenced this pull request May 5, 2023
@aleicazatti aleicazatti deleted the DiscreteWeibull branch May 5, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants