Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logitnormal distribution #206

Merged
merged 2 commits into from
Feb 11, 2023
Merged

add logitnormal distribution #206

merged 2 commits into from
Feb 11, 2023

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Feb 10, 2023

  • The entropy is approximated to the one from the normal, will fix in a separated PR
  • The mean and var are estimated by sampling. There are other numerical method that could be a better idea. Also deferred to another PR.
  • Code style is correct (follows pylint and black guidelines)
  • Includes new or updated tests to cover the new feature
  • New features are properly documented (with an example if appropriate)

@codecov-commenter
Copy link

Codecov Report

Merging #206 (2086247) into main (a209e3a) will decrease coverage by 0.06%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   83.42%   83.37%   -0.06%     
==========================================
  Files          26       26              
  Lines        2872     2941      +69     
==========================================
+ Hits         2396     2452      +56     
- Misses        476      489      +13     
Impacted Files Coverage Δ
preliz/distributions/__init__.py 100.00% <ø> (ø)
preliz/tests/test_maxent.py 100.00% <ø> (ø)
preliz/tests/test_mle.py 100.00% <ø> (ø)
preliz/tests/test_quartile.py 100.00% <ø> (ø)
preliz/distributions/continuous.py 92.90% <89.70%> (-0.20%) ⬇️
preliz/internal/distribution_helper.py 95.65% <100.00%> (+0.09%) ⬆️
preliz/tests/test_distributions.py 100.00% <100.00%> (ø)
preliz/distributions/discrete.py 92.28% <0.00%> (-1.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aloctavodia aloctavodia merged commit 6f9147a into main Feb 11, 2023
@aloctavodia aloctavodia deleted the logitnormal branch February 11, 2023 12:59
This was referenced Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants