Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BetaBinomial distribution #200

Merged
merged 9 commits into from
Feb 2, 2023
Merged

Conversation

aleicazatti
Copy link
Collaborator

Description

WIP because pz.quartile function didn't work with this distribution, yet to find out why

Checklist

  • Code style is correct (follows pylint and black guidelines)
  • Includes new or updated tests to cover the new feature
  • New features are properly documented (with an example if appropriate)
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)

aleicazatti and others added 6 commits February 1, 2023 14:35
Co-authored-by: Osvaldo A Martin <aloctavodia@gmail.com>
Calculate n as np.int64(mean + sigma * 2), as n must be an integer
Add maxent test lines with and without a fixed n value
@aleicazatti aleicazatti changed the title [WIP] Add BetaBinomial distribution Add BetaBinomial distribution Feb 2, 2023
aleicazatti and others added 2 commits February 2, 2023 19:00
Co-authored-by: Osvaldo A Martin <aloctavodia@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #200 (9010a7b) into main (23a7fef) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   83.16%   83.38%   +0.22%     
==========================================
  Files          26       26              
  Lines        2697     2733      +36     
==========================================
+ Hits         2243     2279      +36     
  Misses        454      454              
Impacted Files Coverage Δ
preliz/internal/distribution_helper.py 97.56% <ø> (ø)
preliz/tests/test_maxent.py 100.00% <ø> (ø)
preliz/tests/test_mle.py 100.00% <ø> (ø)
preliz/tests/test_quartile.py 100.00% <ø> (ø)
preliz/distributions/__init__.py 100.00% <100.00%> (ø)
preliz/distributions/discrete.py 97.41% <100.00%> (+0.39%) ⬆️
preliz/tests/test_distributions.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aloctavodia aloctavodia merged commit 72783c7 into arviz-devs:main Feb 2, 2023
@aleicazatti aleicazatti deleted the BetaBinomial branch February 3, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants