Add from_tau and to_tau functions to continuous module #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleicazatti
changed the title
|
I think the functions should be inside the continuous module, instead of being part of the base class. Mostly because not all continuous distributions need those methods. |
aleicazatti
changed the title
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 77.38% 77.17% -0.21%
==========================================
Files 16 16
Lines 1835 1827 -8
==========================================
- Hits 1420 1410 -10
- Misses 415 417 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aloctavodia
reviewed
Nov 25, 2022
preliz/distributions/continuous.py
Outdated
| @@ -16,6 +16,26 @@ | |||
| eps = np.finfo(float).eps | |||
|
|
|||
|
|
|||
| class TauSigma: | |||
There was a problem hiding this comment.
No need to define a class, just define the two functions and call them from within each distribution you need to.
aleicazatti
changed the title
aleicazatti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To define both functions only once in the library, close #112.