Support multichain ppc in plot_ppc #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will wait |
ahartikainen
force-pushed
the
bugfix/multichain_ppcplot
branch
from
3711d6f
to
0e2277e
Compare
|
Now the scatter is more flexible Data count 30 & 10
Data count 30 & 1000
|
ahartikainen
force-pushed
the
bugfix/multichain_ppcplot
branch
from
44169a1
to
a02d401
Compare
|
I think the default value of jitter should be 0/None. Adding jitter can make the samples to overlap, and thus hiding the inter-sample variability. |
|
Sounds reasonable. I will change it. |
|
There is something wrong with travis. Forestplot works (I removed problematic code). So I think this can wait until it is merged. |
canyon289
force-pushed
the
bugfix/multichain_ppcplot
branch
from
1a2f118
to
1cba922
Compare
|
Rebased on master for TravisCI fix |
|
LGTM, I will merge this now. |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multichain ppc.
Also implements jitter for scatter and changes alpha defaults for scatter.