use constant gap for rank plots #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2180 +/- ##
=======================================
Coverage 89.95% 89.96%
=======================================
Files 119 119
Lines 12398 12401 +3
=======================================
+ Hits 11153 11156 +3
Misses 1245 1245
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
OriolAbril
reviewed
Dec 7, 2022
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
OriolAbril
approved these changes
Dec 8, 2022
OriolAbril
reviewed
Dec 8, 2022
CHANGELOG.md
Outdated
| @@ -23,6 +23,8 @@ | |||
|
|
|||
| ### Maintenance and fixes | |||
| - Fix dimension ordering for `plot_trace` with divergences ([2151](https://github.com/arviz-devs/arviz/pull/2151)) | |||
| - Fix gap for `plot_trace` with option `kind="rank_bars"` ([2180](https://github.com/arviz-devs/arviz/pull/2180)) | |||
There was a problem hiding this comment.
this ended up in the 0.14 section instead of the unreleased, other than that it is good to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2177. That issue is a good example of where we will benefit from decoupling computation from plotting. Currently, we compute the ranks, use the values to set the space between chains and plot that. And repeat for the next dimension of the variable.
In the meantime, this PR takes a simpler approach and set a constant gap, of two times the expected height of the uniform distribution. When the rank plot is fine this gap should be enough to make the plots looks nice. Although it will allow overlaps between bars from different chains when the rank deviates more than 2 times the expected uniform distribution. I think that's fine, because if you have such overlap then, you have bigger issues than aesthetics :-)
Checklist
📚 Documentation preview 📚: https://arviz--2180.org.readthedocs.build/en/2180/