Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed fill_last, contour and plot_kwargs arguments #2085

Merged

Conversation

agustinaarroyuelo
Copy link
Contributor

@agustinaarroyuelo agustinaarroyuelo commented Aug 6, 2022

Description

This PR resolves #2073 by removing unused arguments from plot_pair

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2085.org.readthedocs.build/en/2085/

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #2085 (001aa8e) into main (fd27b97) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
+ Coverage   90.77%   90.78%   +0.01%     
==========================================
  Files         117      117              
  Lines       12488    12484       -4     
==========================================
- Hits        11336    11334       -2     
+ Misses       1152     1150       -2     
Impacted Files Coverage Δ
arviz/plots/pairplot.py 92.00% <ø> (+3.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@OriolAbril OriolAbril linked an issue Aug 6, 2022 that may be closed by this pull request
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I have added the issue to the right sidebar (on the development section) so it is closed automatically. I know that happens automatically if some keywords are used when mentioning the issue, will search for them, looks like addressed is not one of them

CHANGELOG.md Outdated Show resolved Hide resolved
@OriolAbril
Copy link
Member

Also, it is cool to see the rtd preview link injection working in the PR description! 🎉

📚 Documentation preview 📚 https://arviz--2085.org.readthedocs.build/en/2085/

Re keywords, it looks like is is fix, close, resolve (also valid in 3rd person present or past forms), reference: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@agustinaarroyuelo agustinaarroyuelo removed the request for review from aloctavodia August 6, 2022 22:42
@OriolAbril OriolAbril merged commit 360697b into arviz-devs:main Aug 8, 2022
@OriolAbril OriolAbril added this to the v0.13 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove deprecated arguments from plot_pair()
2 participants