Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed heading structure to maintain symmetry #1936

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fixed heading structure to maintain symmetry #1936

merged 1 commit into from
Nov 9, 2021

Conversation

roshnaeem
Copy link
Contributor

Description

On the Contributing page, the links in the bullet points are not on the same level. Heading-1 should only be the title of the page, but contributing_prs.md consisted of a lot of first-level headings. Fixed the heading levels to maintain the symmetry.

@OriolAbril
Copy link
Member

I think it would be best to do it as part of #1903, because there the hierarchy is also modified. Here or there works fine by me as the end result will be the same, but doing two separate PRs will probably mean rebases and git conficts on your end

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1936 (872cc5f) into main (f5977ca) will not change coverage.
The diff coverage is n/a.

❗ Current head 872cc5f differs from pull request most recent head 738cd47. Consider uploading reports for the commit 738cd47 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1936   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         116      116           
  Lines       12362    12362           
=======================================
  Hits        11339    11339           
  Misses       1023     1023           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5977ca...738cd47. Read the comment docs.

@roshnaeem
Copy link
Contributor Author

It is fine, you can merge it, I'll rebase the other PR with main.

@OriolAbril OriolAbril merged commit c3cb1ef into arviz-devs:main Nov 9, 2021
@roshnaeem roshnaeem deleted the fix-hierarchy branch November 15, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants