Enabled pylint generator checks #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MgeeeeK
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1588 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 108 108
Lines 11584 11584
=======================================
Hits 10432 10432
Misses 1152 1152
Continue to review full report at Codecov.
|
|
Hi @OriolAbril , you can take a look now |
MgeeeeK
changed the title
OriolAbril
reviewed
Mar 1, 2021
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ | |||
| * Integrate `index_origin` with all the library ([1201](https://github.com/arviz-devs/arviz/pull/1201)) | |||
| * Fix pareto k threshold typo in reloo function ([1580](https://github.com/arviz-devs/arviz/pull/1580)) | |||
| * Preserve shape from Stan code in `from_cmdstanpy` ([1579](https://github.com/arviz-devs/arviz/pull/1579)) | |||
| * Enabled pylint `use-a-generator` and `consider-using-generator` checks ([1588](https://github.com/arviz-devs/arviz/pull/1588)) | |||
There was a problem hiding this comment.
I would write something like Use generators instead of lists whenever possible, users reading the changelog and using arviz may not even know what pylint is, not sure they would understand what this change is.
There was a problem hiding this comment.
Sure, that makes sense.
OriolAbril
approved these changes
Mar 3, 2021
|
Thanks! |
utkarsh-maheshwari
pushed a commit
to utkarsh-maheshwari/arviz
that referenced
this pull request
May 27, 2021
* Enabled pylint generator check * Fixed generator related warnings raised by pylint * Updated the changelog * Changed the changelog msg Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled 2 pylint checks namely:
use-a-generatorconsider-using-generatorFix #1578
Checklist