Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plot_pair labels #1533

Merged
merged 2 commits into from
Feb 6, 2021
Merged

fix plot_pair labels #1533

merged 2 commits into from
Feb 6, 2021

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Feb 4, 2021

Description

Fixes #1531. This PR makes only a couple minor changes to plot_pair. The first one is to
fix the generation of the plot labels and the second is to avoid calling filter twice. As
plot_pair generates a half grid of plots, its interpretation of max_subplots is not done on
the number of variables like with most other plots but on the actual number of subplots, may not be
ideal but the filtering is currently implemented at the backend level.

Checklist

  • Does the PR follow official
    PR format?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the fix listed in the Maintenance and fixes
    section of the changelog?

@michaelosthege
Copy link
Contributor

@OriolAbril
Copy link
Member Author

The error in the failing job does not make any sense to me https://dev.azure.com/ArviZ/ArviZ/_build/results?buildId=3851&view=logs&j=af9a1d3a-ff8f-5483-6823-86518c773a9b&t=d1f9f1df-bd17-5f75-5a7b-8e272c593e8b&l=83

Yeah, there is something going on with pyjags, we have disabled all its test temporally. I expect everything to work now and will make a patch release.

@OriolAbril OriolAbril merged commit 1193532 into main Feb 6, 2021
@OriolAbril OriolAbril deleted the pairplot branch February 6, 2021 10:55
utkarsh-maheshwari pushed a commit to utkarsh-maheshwari/arviz that referenced this pull request May 27, 2021
* fix plot_pair labels

* add to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_pair axis labels no longer include coords
2 participants