[docs] Tabs for example gallery! #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriolAbril
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1521 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 105 105
Lines 11330 11330
=======================================
Hits 10398 10398
Misses 932 932 Continue to review full report at Codecov.
|
AlexAndorra
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
Love it @OriolAbril 😍
Must have been a bit hard to refactor, from what I saw 😅 But the display is much cleaner now 👌
These dependencies were needed to save bokeh plots as png, which is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As proposed in #1484, this PR modifies the example gallery to have a single page per type of plot.
Each page has then one tab per backend to ease comparison between backends.
You can see the preview at https://oriolabril.github.io/arviz/examples/index.html, let me know what you think about it.
Also, side note, now only one thumb per example is required, therefore, we can use matplotlib to generate thumbs and forget about exporting bokeh plots as png files and the extra dependencies it requires which I believe will simplify building docs locally.
Checklist
PR format?
section of the changelog?