add skipna argument to plot_posterior #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
- Coverage 91.97% 91.96% -0.01%
==========================================
Files 105 105
Lines 11173 11179 +6
==========================================
+ Hits 10276 10281 +5
- Misses 897 898 +1
Continue to review full report at Codecov.
|
canyon289
reviewed
Oct 28, 2020
arviz/plots/plot_utils.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| point_value : float | ||
| best estimate of data distribution | ||
| """ | ||
| print("ski", skipna) |
canyon289
reviewed
Oct 28, 2020
| @@ -579,7 +585,10 @@ def calculate_point_estimate(point_estimate, values, bw="default", circular=Fals | |||
| else: | |||
| point_value = mode(values)[0][0] | |||
| elif point_estimate == "median": | |||
| point_value = np.median(values) | |||
| if skipna: | |||
There was a problem hiding this comment.
We should add tests for this specific function as well at the plotting level
There was a problem hiding this comment.
I have added a test for skipna (True or False) for both matplotlib and bokeh. What else is needed?
|
@canyon289 I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plot posterior fails if
nanare present, this adds a skipna argument, defaults to False.