Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pin from mpl 3.3 #1352

Merged
merged 3 commits into from
Aug 16, 2020
Merged

remove pin from mpl 3.3 #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce2479a
remove pin from mpl 3.3
ahartikainen Aug 16, 2020
89524a6
fix duplicate color
Aug 16, 2020
064b3a7
fix return a tuple
Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions arviz/plots/backends/matplotlib/pairplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ def plot_pair(
UserWarning,
)

if reference_values_kwargs is None:
reference_values_kwargs = {}
reference_values_kwargs = matplotlib_kwarg_dealiaser(reference_values_kwargs, "plot")

reference_values_kwargs.setdefault("color", "C3")
reference_values_kwargs.setdefault("marker", "o")
Expand Down
8 changes: 4 additions & 4 deletions arviz/plots/backends/matplotlib/ppcplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ def _set_animation(
def animate(i):
x_vals, y_vals = kde(pp_sampled_vals[i])
line.set_data(x_vals, y_vals)
return line
return (line,)

else:
vals = pp_sampled_vals[0]
Expand All @@ -407,7 +407,7 @@ def animate(i):
def animate(i):
x_vals, y_vals = _empirical_cdf(pp_sampled_vals[i])
line.set_data(x_vals, y_vals)
return line
return (line,)

elif kind == "scatter":
x_vals = pp_sampled_vals[0]
Expand All @@ -418,14 +418,14 @@ def animate(i):

def animate(i):
line.set_xdata(np.ravel(pp_sampled_vals[i]))
return line
return (line,)

def init():
if kind != "scatter":
line.set_data([], [])
else:
line.set_xdata([])
return line
return (line,)

return animate, init

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
matplotlib>=3.0,<3.3
matplotlib>=3.0
numpy>=1.12
scipy>=0.19
packaging
Expand Down