[WIP] add new examples for plot_pair #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectormz
reviewed
Mar 8, 2020
| @@ -0,0 +1,24 @@ | |||
| """ | |||
| Point Estimate Pairplor | |||
There was a problem hiding this comment.
Hi @agustinaarroyuelo I was checking out your new examples and noticed your docstrings for the example .py files say Pairplor instead of what I assume should be Pairplot.
And the files don't end in newlines, which PEP8 doesn't like
There was a problem hiding this comment.
Hi, thanks for letting me know!
|
Maybe we should also update the plot_joint example to use |
|
Should the example for |
run black fix hexbin_kwargs error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added new examples for plot_pair. I tried to showcase in them the possibility of obtaining cornerplots, as mentioned in #1079. I also fixed some bugs. This PR solves #1105 .
I tried to build the documentation locally, but I was having trouble with docker. I was later explained that this isn't a requirement.
Checklist