Skip to content

Commit

Permalink
fix point_estimate mode (#1552)
Browse files Browse the repository at this point in the history
Co-authored-by: Oriol (ZBook) <oriol.abril.pla@gmail.com>
  • Loading branch information
aloctavodia and OriolAbril committed Feb 10, 2021
1 parent 78ec5a0 commit 718eb31
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

## v0.x.x Unreleased
### New features
* Added `to_zarr` method to InferenceData
* Added `from_zarr` method to InferenceData
* Added confidence interval band to auto-correlation plot ([1535](https://github.com/arviz-devs/arviz/pull/1535))
* Added `to_zarr` and `from_zarr` methods to InferenceData ([1518](https://github.com/arviz-devs/arviz/pull/1535))
* Added confidence interval band to auto-correlation plot ([1535](https://github.com/arviz-devs/arviz/pull/1535))

### Maintenance and fixes
* Updated `from_cmdstan` and `from_numpyro` converter to follow schema convention ([1541](https://github.com/arviz-devs/arviz/pull/1541) and [1525](https://github.com/arviz-devs/arviz/pull/1525))
* Fix calculation of mode as point estimate ([1552](https://github.com/arviz-devs/arviz/pull/1552))

### Deprecation
* Removed Geweke diagnostic ([1545](https://github.com/arviz-devs/arviz/pull/1545))
* Removed Geweke diagnostic ([1545](https://github.com/arviz-devs/arviz/pull/1545))

### Documentation

Expand Down
2 changes: 1 addition & 1 deletion arviz/plots/plot_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ def calculate_point_estimate(point_estimate, values, bw="default", circular=Fals
else:
point_value = np.mean(values)
elif point_estimate == "mode":
if isinstance(values[0], float):
if values.dtype.kind == "f":
if bw == "default":
if circular:
bw = "taylor"
Expand Down

0 comments on commit 718eb31

Please sign in to comment.