Fix mmap error when reading empty file during resume check on Linux #7808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are tests with torrents that have 0-size files. Is this issue specifically when files that (when completed) are not 0-sized, but happens to have 0-size on disk during checking? We would need an automated test to trigger this as well |
|
Exactly, you got it right. |
|
I added larger files to |
|
sorry for the delay. thanks! |
|
No problem, thanks for reviewing and merging! |
|
Windows seemed to have a similar issue (at least in CI), addressed by this follow-up commit: e7ac22e |
|
Appreciate you stepping in to handle the Windows side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7790, where calling
mmap()with length = 0 on Linux causes an-EINVALerror during the resume check process.