FIX(peer_list): clear the m_candidate_cache when clear peer_list, and…

[Lwxiang]

… set m_num_seeds to 0

[Lwxiang]

when user call torrent_handle::clear_peers(), it will trigger the peer_list::clear().

then the m_candidate_cache which contains the pointers of peers should also be cleaned after the pointers being freed. I believe this issue causes some crash in #7386 or #7398.

also the m_num_seeds should be reset to 0.

[Lwxiang]

it seems the failing checks is about ssl, @arvidn PTAL

[arvidn]

great catch!
yes, I will have to update the test certificates.

Would you mind extending the unit test to cover this fix as well?

[Lwxiang]

sure, I will add some test later.

[Lwxiang]

already add the clear_peers unit test for peer_list.

before fix, it will not pass the test:

after fix, it pass the test:

[Lwxiang]

@arvidn hi PTAL, can this be merged?

[Lwxiang]

@arvidn seems there are some mistakes with test_resume, the testcase compares the microsecond-duration with second-duration.