Add support for figcaption "title" option and keepAlt flag #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day!
First off, thank you for the work that's been put into this excellent library.
This PR includes everything from #40, building off of Antonio-Laguna's excellent work, while also incorporating all of @arve0's suggestions and keeping backwards compatibility.
New Features
Updates
figcaption
flag to take one of the stringsalt
ortitle
, in addition to aboolean
value (as now).title
option provides the feature that Antonio-Laguna's code introduced, creating thefigcaption
from the image'stitle
attribute rather than thealt
attribute.alt
option is the same astrue
, and provides the existing behavior (creating thefigcaption
from the image'salt
attribute).Adds new
keepAlt
flag which takes a boolean value (defaults to false).true
, andfigcaption
is set totrue
oralt
, this keeps thealt
attribute text in theimg
tag, rather than blanking it out (the existing / default behavior).I also 8 new tests (and updated some existing ones) to cover the changes, and updated the README accordingly.
Fixes #20 & #39.
Please let me know if there's any changes I need to make. Thanks for your time!