Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSAGH-496 Tolerance set in Analyse, Create model component not working. #720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DominikaLos
Copy link
Collaborator

image

@psarras psarras requested a review from ajha0112 October 31, 2024 14:46
@psarras
Copy link
Collaborator

psarras commented Oct 31, 2024

@ajha0112 could you have a look at the phrasing please? We want to nail down the issue that the users are not confused what this tolerance setting means. They thought it mean tolerance of the GSA document, but actually it refers to a particular operation/calculation we are doing.

@psarras psarras changed the title GSAGH-496 Tolerance set in Analyse, Create model component not working. gsagh-496 Tolerance set in Analyse, Create model component not working. Oct 31, 2024
@psarras psarras changed the title gsagh-496 Tolerance set in Analyse, Create model component not working. GSAGH-496 Tolerance set in Analyse, Create model component not working. Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.1%. Comparing base (76bde13) to head (d8e6346).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #720   +/-   ##
=====================================
  Coverage   90.1%   90.1%           
=====================================
  Files        520     520           
  Lines      39291   39296    +5     
  Branches    4902    4902           
=====================================
+ Hits       35436   35441    +5     
  Misses      2582    2582           
  Partials    1273    1273           
Files with missing lines Coverage Δ
GsaGH/Components/ToleranceContextMenu.cs 85.2% <100.0%> (+1.3%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants