Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatible for no config #222

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Conversation

whxaxes
Copy link
Member

@whxaxes whxaxes commented Dec 9, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

当 config 目录不存在时,scan 不报错

@whxaxes whxaxes changed the title feat: compatible for no config fix: compatible for no config Dec 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 92.42% // Head: 92.66% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (7d97cab) compared to base (02e6a28).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   92.42%   92.66%   +0.24%     
==========================================
  Files          55       55              
  Lines        1294     1296       +2     
  Branches      216      218       +2     
==========================================
+ Hits         1196     1201       +5     
+ Misses         98       95       -3     
Impacted Files Coverage Δ
src/plugin/impl.ts 84.90% <50.00%> (ø)
src/scanner/scan.ts 95.94% <100.00%> (+1.42%) ⬆️
src/utils/fs.ts 100.00% <100.00%> (+10.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/scanner/scan.ts Outdated Show resolved Hide resolved
Copy link
Member

@hyj1991 hyj1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whxaxes whxaxes merged commit d790874 into master Dec 12, 2022
@whxaxes whxaxes deleted the feat-compatible-for-no-config branch December 12, 2022 02:22
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants