Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(exception): static error class & remove exception handler #208

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

noahziheng
Copy link
Member

@noahziheng noahziheng commented Oct 19, 2022

refer to artusjs/spec#27

@noahziheng noahziheng force-pushed the refactor/exception-handler branch from 2424b95 to ee4bbac Compare October 19, 2022 06:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 91.92% // Head: 91.92% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2424b95) compared to base (d500fb9).
Patch coverage: 96.42% of modified lines in pull request are covered.

❗ Current head 2424b95 differs from pull request most recent head ee4bbac. Consider uploading reports for the commit ee4bbac to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   91.92%   91.92%   -0.01%     
==========================================
  Files          52       51       -1     
  Lines        1226     1201      -25     
  Branches      186      185       -1     
==========================================
- Hits         1127     1104      -23     
+ Misses         99       97       -2     
Impacted Files Coverage Δ
src/exception/index.ts 100.00% <ø> (ø)
src/exception/impl.ts 96.15% <96.15%> (ø)
src/application.ts 90.90% <100.00%> (-0.40%) ⬇️
src/loader/impl/exception.ts 90.00% <100.00%> (-1.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@noahziheng noahziheng merged commit f7e615b into artusjs:master Oct 19, 2022
@noahziheng noahziheng deleted the refactor/exception-handler branch October 19, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants