Skip to content

More accurate butter knife and dagger2 excludes #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

More accurate butter knife and dagger2 excludes #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...n/groovy/com/dicedmelon/gradle/jacoco/android/JacocoAndroidUnitTestReportExtension.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,18 @@ class JacocoAndroidUnitTestReportExtension {
'**/Manifest*.*'].asImmutable()

public static final Collection<String> butterKnifeExcludes =
['**/*$ViewInjector*.*',
'**/*$ViewBinder*.*'].asImmutable()
['**/*_ViewInjector*.*',
'**/*_ViewBinding*.*',
'**/*_ViewBinder*.*'].asImmutable()

public static final Collection<String> dagger2Excludes =
['**/*_MembersInjector.class',
['**/*_MembersInjector*.class',
'**/Dagger*Component.class',
'**/Dagger*Component$Builder.class',
'**/*Module_*Factory.class'].asImmutable()
'**/*_*Factory*.*',
'**/*Component*.*',
'**/*Subcomponent*.*',
'**/*Module*.*'].asImmutable()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem like common names that not only Dagger is using. I know that at my company, we have a fair number of *Module.java files that definitely need coverage. Component also seems uncommon, but not exclusive to Dagger.

Do you think it might be better to restrict these excludes to the buildDir/generated directory?


public static final Collection<String> defaultExcludes =
(androidDataBindingExcludes + androidExcludes + butterKnifeExcludes + dagger2Excludes)
Expand Down