-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add canary deployment to reaction PRs #3168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsy-peril
bot
added
the
Version: Patch
Indicates that this PR should have a patch deploy, usually for bug fixes
label
Feb 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #3168 +/- ##
========================================
- Coverage 82.7% 82.6% -0.1%
========================================
Files 763 763
Lines 11430 11430
Branches 2260 2260
========================================
- Hits 9453 9452 -1
- Misses 1366 1367 +1
Partials 611 611 |
zephraph
added
Version: Trivial
This indicates that the PR does not need a deploy
and removed
Version: Patch
Indicates that this PR should have a patch deploy, usually for bug fixes
labels
Feb 18, 2020
I'm gonna ship this 🚀 |
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses artsy/orbs#86 to automatically publish canaries from any branch PRs added to reaction.
For some historical context, we've occasionally ran into the need to publish a standalone version of reaction from a PR to be able to use in a review app to test complicated functionality. Updates to the artist app, the experimental app shell, and the styled-components upgrade are all examples of this.
We recently added documentation (#3156) about how to manually trigger a deployment process. Auto already has the ability to do this automatically, but we were blocked by a breaking change update. Given that the update is complete, this PR enables that functionality so we don't have to worry about manually creating canaries.
We'll need to consider if it'll create too much noise for automated PRs like renovate.
📦 Published PR as canary version:
25.11.1-canary.3168.51833.0
✨ Test out this PR locally via:
npm install @artsy/reaction@25.11.1-canary.3168.51833.0 # or yarn add @artsy/reaction@25.11.1-canary.3168.51833.0