-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: imports #37
fix: imports #37
Conversation
@@ -22,7 +22,7 @@ export const SkeletonLoaders = () => ( | |||
<Spacer y={2} /> | |||
|
|||
<Flex flexDirection="row" flexWrap="wrap"> | |||
{range(100)(1).map((index) => ( | |||
{range(1, 100).map((index) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest @damassi, i would use remeda's range
this way anyway. unless it was in some pipe situation.
@@ -22,7 +22,7 @@ export const SkeletonLoaders = () => ( | |||
<Spacer y={2} /> | |||
|
|||
<Flex flexDirection="row" flexWrap="wrap"> | |||
{range(100)(1).map((index) => ( | |||
{range(1, 100).map((index) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be range(100).map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah true. i didnt see what its doing, just "fixed" it for lodash.
🚀 PR was released in |
tiny fix
📦 Published PR as canary version:
3.5.2--canary.37.3839766875.0
✨ Test out this PR locally via:
npm install @artsy/palette-mobile@3.5.2--canary.37.3839766875.0 # or yarn add @artsy/palette-mobile@3.5.2--canary.37.3839766875.0