feat(Chip): add chip element #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsy-peril
bot
added
Jira Synced
gkartalis
approved these changes
Oct 8, 2024
|
🚀 PR was released in |
iskounen
reviewed
Oct 8, 2024
| </Text> | ||
| )} | ||
| <Text variant="sm-display" selectable={false}> | ||
| {title} |
There was a problem hiding this comment.
@araujobarret I'm curious how this would look when a super long title (ex. "Design Objects and Furniture" is paired with an image. Does the extra text get cut, or does it wrap to the next line?
There was a problem hiding this comment.
it wraps to the next line(you can see in one of the stories from the video) (sorry I've missed the q here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves DIA-920
Description
Add the Chip element according to the DS
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-10-08.at.11.56.06.mp4