refactor(Button): enable loading state for button #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
araujobarret
changed the title
gkartalis
approved these changes
Sep 16, 2024
|
|
||
| {loading ? ( | ||
| {loading && ( |
There was a problem hiding this comment.
🤔 can't believe that this was the issue 🤔
There was a problem hiding this comment.
it wasn't we we missing the loader colors and the transparencies to the text too
There was a problem hiding this comment.
I get that the colors were missing but what about the size of the button? It is not affected by the colors right?
|
Added a missing fix on the follow button here 1929b17 result: Simulator.Screen.Recording.-.iPhone.14.-.2024-09-16.at.17.26.58.mp4 |
gkartalis
approved these changes
Sep 16, 2024
|
🚀 PR was released in |
araujobarret
added a commit
that referenced
this pull request
Sep 18, 2024
This reverts commit 8f6a59c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes loading states similar to what was done in #243.
Co-authored by @gkartalis
Simulator.Screen.Recording.-.iPhone.14.-.2024-09-16.at.16.56.41.mp4