chore: allow disabling keyboard avoidance #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
This PR adds support to disabling keyboard avoidance to
Screen.BodyWhy am I adding this?
When the user dismisses a screen where they had the keyboard visible, the
KeyboardAvoidingViewtakes action of adjusting the screen content in order to fit it within the screen. Most of the cases, this will result in nothing, since there is nothing to push up, however in the case where we have a sticky button (like the case of SWA landing page "Start Selling" button), we will see that button going down along with the keyboard. Which is something you wouldn't expect since the screen wasn't active.Screen.Recording.2024-06-05.at.10.21.58.mov