Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update graphql-tools to unblock looking at schema stitching again #934

Closed
wants to merge 1 commit into from

Conversation

orta
Copy link
Contributor

@orta orta commented Feb 16, 2018

Fixes #836

screen shot 2018-02-16 at 3 44 16 pm

Signed-off-by: Matt Zikherman <mzikherman@gmail.com>
@orta orta assigned sweir27 and unassigned sweir27 Feb 16, 2018
@orta orta changed the title Update graphql-tools to unblock looking at schema stitching again [WIP] Update graphql-tools to unblock looking at schema stitching again Feb 16, 2018
@orta
Copy link
Contributor Author

orta commented Feb 16, 2018

Aha, figured out my issue when trying to figure it out - think we need to apply this: 38be9dc

To the stitched graphql schema also

@orta
Copy link
Contributor Author

orta commented Feb 16, 2018

We found issues with the merged schemas showing Reserved by GraphQL introspection.\n\nName \"__id\" must not begin with \"__\", which is reserved when updating.

It looks like graphql-tools needs to be updated to allow passing graphschema options - there was a PR adding the ability to do that made an hour ago: graphql/graphql-js#1249

To continue, we need to:

  • wait on a graphqljs release
  • need to add a pr to graphql-tools to support passing build options

@orta
Copy link
Contributor Author

orta commented Feb 16, 2018

I fixed this in my node modules, by removing the error reporting, and it worked fine, so I think this is our last blocker before we start thinking about what to do when it is feasible

@joeyAghion
Copy link
Contributor

Looks like 2.22.0 is out. Does this mean this work is unblocked?

@orta
Copy link
Contributor Author

orta commented Mar 16, 2018

Yep, I think so

@mzikherman
Copy link
Contributor

Closing in favor of #979

@mzikherman mzikherman closed this Mar 21, 2018
@orta orta deleted the update_graphql_tools3 branch April 2, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants