Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-2076] Polyfills :focus-visible; adds :focus-visible outlines #5887

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

dzucconi
Copy link
Member

@dzucconi dzucconi commented Jul 6, 2020

Re: FX-2076

So in the gif above you can get a sense of the behavior — a 1px purple focus ring outline will show up only when tabbing/shift+tabbing. What you'll notice is that big pieces of navigation and pages are not accessible via keyboard, and in other places elements have too many focus points making navigation tedious.

I think the most appropriate next steps here are making the global nav accessible — (there's a ticket to create a tech plan for this, cc @sweir27)

I'll make tickets for some of the bigger inaccessible items as well (notably the filter sidebar is totally inaccessible for some reason). We should also install some simple linting rules to guide developers away from sticking onClick handlers on divs, for instance.

The source for the polyfill is here

Support for :focus-visible sans polyfill here

@dzucconi dzucconi force-pushed the feat/FX-2076--focus-visible branch from 7d4d770 to 3e73c07 Compare July 7, 2020 14:53
@dzucconi dzucconi force-pushed the feat/FX-2076--focus-visible branch from 3e73c07 to 167b289 Compare July 8, 2020 14:26
@artsy-peril artsy-peril bot merged commit 2e4731c into artsy:master Jul 8, 2020
@artsy-peril artsy-peril bot mentioned this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants