Upgraded React Native version and fixed Related Artists layout issue #196
Conversation
sarahscott
force-pushed
the
sarah-rn-upgrade
branch
from
7804fef to
e6d35f8
Compare
|
Have you tested that layout issue fix on iPad and also with artists where the related artists don’t fully fill the grid and that the remainder is left aligned? As in, those grid fixes we had to make before when we started testing on iPad. |
|
Just found this ticket facebook/react-native#8607. So we should double check if any scrollviews go blank for us. |
|
Also need to verify that our nested scrollviews monkey-patches still work as expected. i.e. if the artworks grid is still fetching works when you reach the end of the list. |
sarahscott
force-pushed
the
sarah-rn-upgrade
branch
from
e6d35f8 to
1e20835
Compare
sarahscott
changed the title
|
This still has the issue where show titles aren't truncating, but otherwise looks good. The grids re-fetch and align properly. I think it's important to get this merged so our subsequent Home view work doesn't run into layout issues later, so I'm making a separate issue for the text truncation. |
|
I’ve suggested that Libraries.io lists the license of the We can’t do much about those deprecated packages, so this is good on my part. |
| new Relay.DefaultNetworkLayer(metaphysicsURL) | ||
| // headers: { | ||
| // Authorization: 'Basic SECRET' | ||
| // }) |
There was a problem hiding this comment.
This should not be included.
There was a problem hiding this comment.
Which lines in particular should not be included?
There was a problem hiding this comment.
The auth header should not be removed.
sarahscott
force-pushed
the
sarah-rn-upgrade
branch
from
1e20835 to
032b35e
Compare
flex-wrapfor related artistsWith the addition of
alignItems: flex-start, everything is beautiful again:Just like they said: https://github.com/facebook/react-native/releases/tag/v0.28.0