fix(lambda): handle nonzero codes from workers #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobridge
force-pushed
the
bernardobridge/art-1831-handle-non-zero-exit-codes-from-lambda-worker-eg-expect
branch
from
ee181de to
b109989
Compare
bernardobridge
changed the title
bernardobridge
deleted the
bernardobridge/art-1831-handle-non-zero-exit-codes-from-lambda-worker-eg-expect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently errors from workers still make the main CLI process exit with 0. This is inconsistent with Local and Fargate, and can lead to incorrect behaviour in CI and Artillery Cloud (e.g. filtering). Particularly relevant for things like
expect.Note: this API will allow us to define specific exit codes for different types of workerErrors (e.g. TestDataSync), but right now I have just defaulted to 1 for everything. Only in the case of
ArtilleryErrors, it will use the exitCode from the CLI in the worker.Pre-merge checklist