Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: added option for gradient class selection #8

Closed

Conversation

ignatovSA
Copy link
Contributor

Discussion started: #1

My example requires some refinement. Current realization doesn't support animating gradient's properties, so it's suitable only for static views.

Also, it's not very clear to me, how can we pass this CALayer subclass into generated code without overcomplicating it.

My proposal is:

  • Add a possibility to specify linear gradient class name, by adding the parameter in options (Done)
  • add a playground demonstrating sample usage (Todo)
  • Update readme with links and motivation (Todo)

What do you think?

@artemnovichkov
Copy link
Owner

@ignatovSA, thank you for the PRs, they are really helpful!
About gradients. Is it an often task for implementing animatable gradient views? I guess code snippet for static views is enough
About code generation: in my opinion, we should generate the whole view with gradient sublayer. What do you think?
And about Playground with examples and README updating - good idea, I like it! We can add it in the final of gradient implementation

@artemnovichkov
Copy link
Owner

Hi, @ignatovSA! How are you? I have released 0.5.0 version with plenty of changes. Could you please give me a permission to changes? I'll help you with merge conflicts and the implementation.

@artemnovichkov
Copy link
Owner

I made a Playground example: LinearGradientPlayground.zip
screen shot 2018-03-17 at 11 24 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants