-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSBuild errors #1
Comments
Thank you for opening the issue. I did not test it under Windows but it should work with some fixes. I will look into it. |
Hi, sorry for the long response time. I removed the line generating an error ( |
It compiles now, however, several of the tests are failing:
|
Hi, all interested! Unfortunately I don't have a working Windows environment and also have very little free time. |
Hi, cpmessina. The first error has to do with how numpy works in windows. Please look at pybind and stackoverflow. Using dytpe=np.uintc instead of np.uint32 fixes the edge creation tests. |
Hi, @SioulisChris Thank you very much for taking your time and providing the explanation. |
Yes, changing the dtype in cdt_bindings_test.py makes assertions valid. The remaining issue is "Wrong OFF file contents" in Windows. I think that line 190 in cdt_bindings_test.py should be commented out. It hardcodes OFF file as "/tmp/cdt.off" which is problematic in Windows. Saving the triangulation is repeated afterwards in OS independent manner. All the assertions with the hardcoded values fail. I guess the hash codes computed are machine related! If I comment out the hash tests, the remaining tests pass. |
Changed the hash tests in Windows like this: |
Thank you, I updated the branch. Does this work on Windows? It passes on Linux, and I don't have a mac to test on. When I get some time I will add GitHub actions for the three OSes. |
You also need to replace lines 181 & 182 with: |
Again, thank you a lot for your help @SioulisChris |
Windows 10 21H2
Visual Studio 2022
Python 3.10.6
After checking out the git and executing '
pip3 install .
', I'm getting these warnings and error:Not sure where to go from here. Has the PythonCDT been tested under Windows, or just the main CDT code? Any suggestions for getting it to compile?
Ultimately, I'm interested in seeing if this can be utilized in Blender, and at this point I think I just need a Windows compiled version of the PythonCDT module.
Thanks!
The text was updated successfully, but these errors were encountered: