Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Training Microservice (METS validation) #1590

Closed
wants to merge 7 commits into from

Conversation

ross-spencer
Copy link
Contributor

@ross-spencer ross-spencer commented Apr 2, 2020

This commit adds a new METS validation microservice which serves a training purpose around how to develop a basic microservice.

The microservice will reject invalid METS generated by the create METS V2 scripts in the workflow.

TODO

  • Remove create AIP reminder.
  • Excess validation code in write_mets function.

Connected to archivematica/Issues#153
Connected to archivematica/Issues#655
Connected to archivematica/Issues#1129

Black-box tests for this work

@black-box 
Feature: Alma wants to ensure that METS files generated by Archivematica are well-formed and valid.

  Scenario: METS validation passes
    Given a "zipped bag" transfer type located in "SampleTransfers/BagExamples/ZippedBags/BagTransfer.zip"
	When the transfer is approved
    Then the "Verify bag, and restructure for compliance" job completes successfully
    Then the "Validate AIP METS" job completes successfully

  Scenario: METS validation fails
    Given a "zipped bag" transfer type located in "SampleTransfers/BagExamples/Invalid/InvalidBag.zip"
    When the transfer is approved
    Then the "Verify bag, and restructure for compliance" job completes successfully
    And the "Validate AIP METS" job fails

@ross-spencer ross-spencer force-pushed the training/issue-153-picturae-microservice branch from 5a7c7f2 to 859b522 Compare April 2, 2020 01:11
@qubot
Copy link
Contributor

qubot commented Dec 10, 2020

Can one of the admins verify this patch?

@sevein sevein added the stalled Stalled pull requests. label Mar 8, 2021
@sevein sevein closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Stalled pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants