Problem: fiwalk characterization is broken

[sevein]

We have a class in src/archivematicaCommon/lib/externals/fiwalk_plugins/pronom_ident.py that subclasses fido.Fido (from https://github.com/openpreserve/fido).

class FiwalkFido(fido.Fido):
    """docstring for FiwalkFido"""
    # [...]
    def identify_file(self, filename):
        """Identify the type of @param filename."""
        # [...]
        bofbuffer, eofbuffer = self.get_buffers(f, size, seekable=True)

The method get_buffers is treated as it returned a tuple of two items however the method changed a long time ago starting to return a tuple of three items: https://github.com/openpreserve/fido/blob/master/fido/fido.py#L536-L582.

It seems that this change was introduced in v1.3.4-84: openpreserve/fido@d3d5e23.

---

Redmine: https://projects.artefactual.com/issues/11256 (private)

[sromkey]

This should be testable by testing the ISO disk image in sample transfers.