-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix FILEID for pointer file METS creation #473
Conversation
@@ -5,7 +5,6 @@ | |||
# pip-compile --output-file=test.txt test.in | |||
# | |||
agentarchives==0.4.0 | |||
appnope==0.1.0 # via ipython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This deleted itself running the requirements Makefile
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh, I was wondering when this was added. It looks like...ipython requires appnope on os x. See here: https://github.com/ipython/ipython/blob/master/setup.py#L204
53dbb14
to
bfb3f8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ross-spencer!
This looks good, but I wonder about the addition of setuptools
in the test requirements ...
@@ -113,3 +112,6 @@ virtualenv==16.6.0 # via tox | |||
wcwidth==0.1.7 # via prompt-toolkit | |||
whitenoise==3.3.0 | |||
wrapt==1.11.1 | |||
|
|||
# The following packages are considered to be unsafe in a requirements file: | |||
# setuptools==41.0.1 # via ipdb, ipython, pytest, tox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this auto-added too? Should we remove it from the requirements file and require it somewhere else if it's really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed as a team in Slack. There's a little bit of chatter here too: jazzband/pip-tools#522. The follow up is to log a new issue to refine our use of pip-compile some more to catch things like this that may be undesirable.
This commit ensures that IDs and FILEIDs are prefixed when generated for pointer files belonging to an AIP. The prefix along with name clean-up procedures in the transfer/ingest workflow ensures that the ID/FILEID remains consistent with an NC string type as defined by the XML standard.
bfb3f8b
to
9d1606d
Compare
This commit ensures that IDs and FILEIDs are prefixed when
generated for pointer files belonging to an AIP. The prefix along
with name clean-up procedures in the transfer/ingest workflow ensures
that the ID/FILEID remains consistent with an NC string type as
defined by the XML standard.
Connected to archivematica/Issues#660
The output will be a
fileSec
andstructMap
in a pointer file that looks as follows:Note the
ID
andFILEID
in the respective instances are both prefixed withfile-
per the original issue.And this structure will persist following reingest as well which is why this PR: requires artefactual-labs/mets-reader-writer#72
NB. This PR is complicated by the need to use a different
metsrw
. Once the code has been reviewed and approved, I will push the newmetsrw
and then update this PR to change the requirements so they referencemetsrw-0.3.10
.