-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
@jhsimpson can you make sure that the migration is doing the right thing? I've created new commands but I'm not sure if I'm also supposed to create new tools or repurpose the existing ones. If you want to see it in action there is no need to involve AM at all, just build the testproject/ locally following these instructions: https://github.com/artefactual/archivematica-fpr-admin/blob/qa/1.x/DEVELOPMENT.md. |
48e74cb
to
915641b
Compare
915641b
to
814f58a
Compare
Looks like the following two objects need to be removed from migrations/pronom_92.json because these formats are already in the db from initial_data.json:
If the above need to be changed, I think that that needs to happen in migrations/0015_pronom_92.py. |
Good catch, @jrwdunham. For some reason I ran into a bunch of extra items that already existed. |
139c226
to
928cd43
Compare
928cd43
to
e803a88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to successfully follow the instructions at https://github.com/artefactual/archivematica-fpr-admin/blob/qa/1.x/DEVELOPMENT.md and explore the FPR GUI and see the expected changes.
Thank you! Let's hope that d32bf02 doesn't break user upgrades. I'm assuming if that's the case it should be detected during QA. |
This is a sequel of #58. It updates two tools:
Also, two extra commits in order to:
__version__
to1.7.2
(needed for the release)Before this PR:
After this PR:
This was done before in the following migrations but only IDTools were updated.
I see three options:
Once this is merged we need to make sure that:
archivematica-fpr-admin 1.7.2 is releasedfido: archivematica to bundle fido 1.3.7 (Update fido to v1.3.7 archivematica#765)archivematica 1.7 (dashboard, mcpclient) adds archivematica-fpr-admin 1.7.2 to requirementssiegfried: compose/ansible/pkgs(trusty,xenial,centos7) to bundle siegfried 1.7.6(not fixed atm but reported)