Update AIS integration #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 53.48% 54.48% +0.99%
==========================================
Files 29 30 +1
Lines 2023 1986 -37
==========================================
Hits 1082 1082
+ Misses 869 832 -37
Partials 72 72 ☔ View full report in Codecov by Sentry. |
jraddaoui
force-pushed
the
dev/poststorage-ais
branch
from
4c65afd to
7cbe51c
Compare
djjuhasz
reviewed
Nov 7, 2024
djjuhasz
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Thanks @jraddaoui. I made a few comments, but I don't see any deal breakers.
jraddaoui
force-pushed
the
dev/poststorage-ais
branch
from
348ff16 to
7b2b554
Compare
Update AIS integration to use Enduro's poststorage child workflows. - Remove AIS API server. - Remove `AIPName` and make `AIPUUID` a string in AIS `WorkflowParams`. - Add local activity to get the AIP current path from AMSS. - Parse AIP directory name from current path.
jraddaoui
force-pushed
the
dev/poststorage-ais
branch
from
ec76a74 to
fa37e42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AIS integration to use Enduro's poststorage child workflows.
AIPNameand makeAIPUUIDa string in AISWorkflowParams.Related to artefactual-sdps/enduro#886 and artefactual-sdps/enduro#1061.