Fixes to PREMIS event recording #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcantelon
commented
Jul 5, 2024
•
mcantelon
commented
- Removed redundant PREMIS event for validate file formats
- Correct use of improper PREMIS event types
- Allow PREMIS evebt details and PREMIS event outcome detail to be specified rather than generated
- Add PREMIS event outcome detail specification to PREMIS events in workflow and validate file formats activity
- Generate error when attempting to add a PREMIS event to a non-existent PREMIS object
- Fixed issue with validate formats activity
- Removed unneeded code in tests for add PREMIS event activity
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 66.77% 66.59% -0.18%
==========================================
Files 19 19
Lines 936 940 +4
==========================================
+ Hits 625 626 +1
- Misses 261 263 +2
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. |
jraddaoui
approved these changes
Jul 9, 2024
internal/premis/premis.go
Outdated
| @@ -128,30 +129,23 @@ func eventFromEventSummaryAndAgent(eventSummary EventSummary, agent Agent) Event | |||
| } | |||
| } | |||
|
|
|||
| func NewEventSummary(eventType string, failures []string) (EventSummary, error) { | |||
| detail, outcome := assembleEventDetailAndOutcome(failures) | |||
| func NewEventSummary(eventType string, detail string, outcomeDetail string, failures []string) (EventSummary, error) { | |||
There was a problem hiding this comment.
Do we still need to pass the slice of failures, could we use a boolean or pass the outcome directly.
There was a problem hiding this comment.
Good call... that'd make it more straightforward.
|
Thanks @jraddaoui ! |
mcantelon
force-pushed
the
dev/premis-event-fixes
branch
from
235a63a to
0efe5bc
Compare
* Removed redundant PREMIS event for validate file formats * Correct use of improper PREMIS event types * Allowed PREMIS evebt details and PREMIS event outcome detail to be specified rather than generated * Add PREMIS event outcome detail specification to PREMIS events in workflow and validate file formats activity * Generate error when attempting to add a PREMIS event to a non-existent PREMIS object * Fixed issue with validate formats activity * Removed unneeded code in tests of add PREMIS event activity
mcantelon
force-pushed
the
dev/premis-event-fixes
branch
from
0efe5bc to
3d4b526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.